Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA32A4960 for ; Mon, 23 May 2011 18:09:28 +0000 (UTC) Received: (qmail 99035 invoked by uid 500); 23 May 2011 18:09:28 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 98953 invoked by uid 500); 23 May 2011 18:09:28 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 98871 invoked by uid 99); 23 May 2011 18:09:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2011 18:09:28 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=5.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2011 18:09:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7EA94D9B27 for ; Mon, 23 May 2011 18:08:47 +0000 (UTC) Date: Mon, 23 May 2011 18:08:47 +0000 (UTC) From: "Matt Foley (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1524465083.36757.1306174127515.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <313989454.72718.1303366505802.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1853) refactor TestNodeCount to import standard node counting and "wait for replication" methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038098#comment-13038098 ] Matt Foley commented on HDFS-1853: ---------------------------------- Removed from HDFS-1852 umbrella task, since not related to recurring Hudson test failures. > refactor TestNodeCount to import standard node counting and "wait for replication" methods > ------------------------------------------------------------------------------------------ > > Key: HDFS-1853 > URL: https://issues.apache.org/jira/browse/HDFS-1853 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 0.22.0 > Reporter: Matt Foley > > Eli's suggestions for refactoring the three "wait for" loops in TestNodeCount for re-usability (similar to what was done for HDFS-1562): You could augment NameNodeAdapter#getReplicaInfo to return excess and live replica counts as well and then just add waitFor[Live|Excess]Replicas methods to DFSTestUtil and have TestNodeCount call them. This way we could re-use them in the other replication tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira