Return-Path: 
 <hdfs-issues-return-19824-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7128548A6
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Fri, 27 May 2011 18:23:39 +0000 (UTC)
Received: (qmail 84020 invoked by uid 500); 27 May 2011 18:23:39 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 83989 invoked by uid 500); 27 May 2011 18:23:39 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 83981 invoked by uid 99); 27 May 2011 18:23:39 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2011 18:23:39 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2011 18:23:37 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 2EBDEE39F3
	for <hdfs-issues@hadoop.apache.org>; Fri, 27 May 2011 18:22:56 +0000 (UTC)
Date: Fri, 27 May 2011 18:22:56 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1522271380.49434.1306520576188.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <935329242.10565.1305305567369.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1936) Updating the layout version from
 HDFS-1822 causes upgrade problems.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HDFS-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040364#comment-13040364 ] 

Todd Lipcon commented on HDFS-1936:
-----------------------------------

Wow, this is so much improved!

- I'm curious why you've changed the test to no longer verify the contents of the filesystem after upgrade for the 0.22 case? The way I generated the 0.22 tarball attached above was to do an upgrade from the 0.14 one, so all of the checksums should be in tact. This will also help ensure that the DN upgrade process works with federation.

- In this code, do we need the if statement? Seems like it would be an error to call this before the feature map is initialized.
{code}
+  private static void specialInit(int lv, Feature f) {
+    EnumSet<Feature> set = map.get(lv);
+    if (set != null) {
+      set.add(f);
+    }
+  }
{code}

- Looks like some spurious changes to DataNode.java?
- Indentation slightly off in loadLocalNameINodes

- This diff looks not quite right - you're checking if FSConstants.LAYOUT_VERSION supports federation, but that's always true in trunk. So, this code will always run. I think you want to check {{!LayoutVersion.supports(Feature.FEDERATION, storage.getLayoutVersion())}} maybe?
{code}
-    if (startOpt == StartupOption.UPGRADE
-        && storage.getLayoutVersion() > Storage.LAST_PRE_FEDERATION_LAYOUT_VERSION) {
+    if (startOpt == StartupOption.UPGRADE && 
+        LayoutVersion.supports(Feature.FEDERATION, FSConstants.LAYOUT_VERSION)) {
{code}



> Updating the layout version from HDFS-1822 causes upgrade problems.
> -------------------------------------------------------------------
>
>                 Key: HDFS-1936
>                 URL: https://issues.apache.org/jira/browse/HDFS-1936
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 0.22.0, 0.23.0
>
>         Attachments: HDFS-1936.3.patch, HDFS-1936.trunk.patch, hadoop-22-dfs-dir.tgz, hdfs-1936-with-testcase.txt
>
>
> In HDFS-1822 and HDFS-1842, the layout versions for 203, 204, 22 and trunk were changed. Some of the namenode logic that depends on layout version is broken because of this. Read the comment for more description.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira