Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 23 May 2011 12:38:47 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1495485443.35817.1306154327432.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1459244597.34730.1306097327448.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1978) All but first option in LIBHDFS_OPTS
 is ignored
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037912#comment-13037912 ] 

Hudson commented on HDFS-1978:
------------------------------

Integrated in Hadoop-Hdfs-trunk #675 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/675/])
    HDFS-1978. All but first option in LIBHDFS_OPTS is ignored. Contributed by Eli Collins

eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1126312
Files : 
* /hadoop/hdfs/trunk/src/c++/libhdfs/hdfsJniHelper.c
* /hadoop/hdfs/trunk/CHANGES.txt


> All but first option in LIBHDFS_OPTS is ignored
> -----------------------------------------------
>
>                 Key: HDFS-1978
>                 URL: https://issues.apache.org/jira/browse/HDFS-1978
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 0.21.0
>         Environment: RHEL 5.5
> JDK 1.6.0_24
>            Reporter: Brock Noland
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1978.0.patch, hdfs-1978-1.patch
>
>
> In getJNIEnv, we go though LIBHDFS_OPTS with strok and count the number of args. Then create an array of options based on that information. But when we actually setup the options we only the first arg. I believe the fix is pasted inline.
> {noformat}
> Index: src/c++/libhdfs/hdfsJniHelper.c
> ===================================================================
> --- src/c++/libhdfs/hdfsJniHelper.c	(revision 1124544)
> +++ src/c++/libhdfs/hdfsJniHelper.c	(working copy)
> @@ -442,6 +442,7 @@
>              int argNum = 1;
>              for (;argNum < noArgs ; argNum++) {
>                  options[argNum].optionString = result; //optHadoopArg;
> +                result = strtok( NULL, jvmArgDelims);
>              }
>          }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira