Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 21 May 2011 00:07:47 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1420251223.32354.1305936467557.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <872511945.8686.1305245447368.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1932) Add utility method to initialize
 HDFS default configurations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037179#comment-13037179 ] 

Todd Lipcon commented on HDFS-1932:
-----------------------------------

Unfortunately there isn't one central place that suffices. I think once HADOOP-7287 is fixed it will be less important to call this in every Tool. Also, in debugging HADOOP-7287 we just noticed that DistributedFileSystem doesn't instantiate HdfsConfiguration at all - so we'll have to add this there. For now, I'm all for being more cautious and having this in too-many spots rather than too-few.

bq. In terms of testing does the test in HADOOP-7287 fail w/o this patch and succeed with it?

This is just a cleanup JIRA. I'll open another one to make sure we initialize it in the right spots (DistributedFileSystem in particular)

> Add utility method to initialize HDFS default configurations
> ------------------------------------------------------------
>
>                 Key: HDFS-1932
>                 URL: https://issues.apache.org/jira/browse/HDFS-1932
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Jolly Chen
>            Priority: Critical
>              Labels: newbie
>         Attachments: hdfs-1932-2.txt, hdfs-1932.txt
>
>
> Currently we have code blocks like the following in lots of places:
> {code}
>   static{
>     Configuration.addDefaultResource("hdfs-default.xml");
>     Configuration.addDefaultResource("hdfs-site.xml");
>   }
> {code}
> This is dangerous since, if we don't remember to also classload HdfsConfiguration, the config key deprecations won't work. We should add a method like HdfsConfiguration.init() which would load the default resources as well as ensure that deprecation gets initialized properly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira