Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 25 May 2011 16:56:47 +0000 (UTC)
From: "Harsh J Chouraria (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1384345375.42707.1306342607879.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-977)
 DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J Chouraria updated HDFS-977:
-----------------------------------

    Attachment: HDFS-977.r2.diff

Sorry about that!

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: HDFS-977.r1.diff, HDFS-977.r2.diff
>
>
> My IDE tells me that this code snippet in {{DataNode.createInterDataNodeProtocolProxy()}} is guarding the info log entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira