From hdfs-issues-return-18509-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org Thu May 12 21:40:30 2011 Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42E3B5BB5 for ; Thu, 12 May 2011 21:40:30 +0000 (UTC) Received: (qmail 74854 invoked by uid 500); 12 May 2011 21:40:29 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 74823 invoked by uid 500); 12 May 2011 21:40:29 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74815 invoked by uid 99); 12 May 2011 21:40:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 21:40:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 21:40:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C54A387BEB for ; Thu, 12 May 2011 21:39:47 +0000 (UTC) Date: Thu, 12 May 2011 21:39:47 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <619905335.8307.1305236387804.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <18540953.158441290026115210.JavaMail.jira@thor> Subject: [jira] [Commented] (HDFS-1505) saveNamespace appears to succeed even if all directories fail to save MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032697#comment-13032697 ] Aaron T. Myers commented on HDFS-1505: -------------------------------------- bq. That is, isOfType() is permissive rather than exclusive. You are quite correct. My mistake. The original logic you posted for the check seems to be correct. bq. Also, since HDFS-1826 copied the concurrent saveNamespace() logic into FSImage.doUpgrade(), would you please add the same code fragment to the end of doUpgrade(), and a corresponding corruption unit test case to TestDFSUpgrade? Thanks. It occurs to me now that the failure handling should perhaps be different between these two cases. i.e. it is acceptable to tolerate some number of storage directory failures during save namespace, but we should perhaps throw an error in the event *any* storage directories fail during upgrade. Thoughts? > saveNamespace appears to succeed even if all directories fail to save > --------------------------------------------------------------------- > > Key: HDFS-1505 > URL: https://issues.apache.org/jira/browse/HDFS-1505 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0, 0.23.0 > Reporter: Todd Lipcon > Assignee: Aaron T. Myers > Priority: Blocker > Fix For: 0.22.0 > > Attachments: hdfs-1505-22.0.patch, hdfs-1505-22.1.patch, hdfs-1505-test.txt, hdfs-1505-trunk.0.patch, hdfs-1505-trunk.1.patch > > > After HDFS-1071, saveNamespace now appears to "succeed" even if all of the individual directories failed to save. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira