hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J Chouraria (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-977) DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
Date Sat, 07 May 2011 10:53:03 GMT

     [ https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Harsh J Chouraria updated HDFS-977:
-----------------------------------

    Attachment: HDFS-977.r1.diff

This is better as a DEBUG log since it may get called repeatedly for recovery blocks?

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Priority: Trivial
>         Attachments: HDFS-977.r1.diff
>
>
> My IDE tells me that this code snippet in {{DataNode.createInterDataNodeProtocolProxy()}}
is guarding the info log entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message