hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1925) SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
Date Wed, 18 May 2011 22:24:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035800#comment-13035800
] 

Todd Lipcon commented on HDFS-1925:
-----------------------------------

I'm impressed by the valiant effort to make a regression test, but I think the test itself
is too fragile for what's essentially a code cleanup. +1 on the fix but -1 on the test :)
Assuming the test-patch comes back clean I'll commit just the fix part.

> SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-1925
>                 URL: https://issues.apache.org/jira/browse/HDFS-1925
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>            Assignee: Joey Echeverria
>              Labels: newbie
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1925-1.patch
>
>
> {{SafeMode()}} constructor has 0.95f default threshold hard-coded. This should be replaced
by the constant {{DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT}}, which is correctly set to
0.999f.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message