hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1592) Datanode startup doesn't honor volumes.tolerated
Date Mon, 23 May 2011 04:37:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037726#comment-13037726
] 

Eli Collins commented on HDFS-1592:
-----------------------------------

Hey Bharath,

Apologies for the slow response, I didn't see the jira updates for some reason.  Thanks for
adding the tests, the new test cases look good. I think other types of faults can be handled
in a separate jira.

Some minor comments, otherwise looks great!

* DataStorage#recoverTransitionRead should log the IOE now that it's swallowed instead of
thrown
* It would be more clear to users if the message in the exception thrown FSDataSet was something
like "Too many failed volumes". Since "volumes required" is an internal variable rather than
a config option users won't what "Invalid value for volumes required" means.
* Nit: volsConfigured can be initialized in 1 line: {{int volsConfigured = (dataDirs == null)
? 0 : dataDirs.length}}
* startCluster should probably be renamed restartCluster since it's always called on active
clusters
* Jitendra's comment wrt refactoring makes sense

Thanks,
Eli

> Datanode startup doesn't honor volumes.tolerated 
> -------------------------------------------------
>
>                 Key: HDFS-1592
>                 URL: https://issues.apache.org/jira/browse/HDFS-1592
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.204.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>             Fix For: 0.20.204.0, 0.23.0
>
>         Attachments: HDFS-1592-1.patch, HDFS-1592-2.patch, HDFS-1592-3.patch, HDFS-1592-4.patch,
HDFS-1592-rel20.patch
>
>
> Datanode startup doesn't honor volumes.tolerated for hadoop 20 version.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message