hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-977) DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
Date Wed, 25 May 2011 18:07:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039251#comment-13039251

Hadoop QA commented on HDFS-977:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1127390.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these core unit tests:

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//console

This message is automatically generated.

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.23.0
>         Attachments: HDFS-977.r1.diff, HDFS-977.r2.diff
> My IDE tells me that this code snippet in {{DataNode.createInterDataNodeProtocolProxy()}}
is guarding the info log entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message