hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1505) saveNamespace appears to succeed even if all directories fail to save
Date Tue, 17 May 2011 02:37:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034506#comment-13034506

Aaron T. Myers commented on HDFS-1505:

bq. Hi Aaron, sorry to keep harping on this (and this was likely a typo), but the test needs
to be

This was my goof. I made the test changes on the trunk branch but got mixed up and made the
changes to address your comments on my 0.22 branch. I'll attach a patch shortly with all the

bq. The TestSaveNamespace mod looks good.


Are you still going to address this one?

I would suggest fixing the lack of notification in FSEditLog.open(), but also in your patch
to saveNamespace() the check for empty IMAGE and EDITS lists should precede the call to editLog.open().

Yep - same deal as the above.

bq. BTW, after thinking about your comment, I think I will change doUpgrade() to fail on any
bad storage dir, the way it used to before HDFS-1826. I'll do that under HDFS-1921 since I'm
in FSImage anyway. Sound okay?

That sounds fine to me.

> saveNamespace appears to succeed even if all directories fail to save
> ---------------------------------------------------------------------
>                 Key: HDFS-1505
>                 URL: https://issues.apache.org/jira/browse/HDFS-1505
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Aaron T. Myers
>            Priority: Blocker
>             Fix For: 0.22.0
>         Attachments: hdfs-1505-1-test.txt, hdfs-1505-22.0.patch, hdfs-1505-22.1.patch,
hdfs-1505-test.txt, hdfs-1505-trunk.0.patch, hdfs-1505-trunk.1.patch, hdfs-1505-trunk.2.patch
> After HDFS-1071, saveNamespace now appears to "succeed" even if all of the individual
directories failed to save.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message