hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1978) All but first option in LIBHDFS_OPTS is ignored
Date Mon, 23 May 2011 04:17:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037723#comment-13037723
] 

Hadoop QA commented on HDFS-1978:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480078/hdfs-1978-1.patch
  against trunk revision 1125879.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/609//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/609//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/609//console

This message is automatically generated.

> All but first option in LIBHDFS_OPTS is ignored
> -----------------------------------------------
>
>                 Key: HDFS-1978
>                 URL: https://issues.apache.org/jira/browse/HDFS-1978
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 0.21.0
>         Environment: RHEL 5.5
> JDK 1.6.0_24
>            Reporter: Brock Noland
>            Assignee: Eli Collins
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1978.0.patch, hdfs-1978-1.patch
>
>
> In getJNIEnv, we go though LIBHDFS_OPTS with strok and count the number of args. Then
create an array of options based on that information. But when we actually setup the options
we only the first arg. I believe the fix is pasted inline.
> {noformat}
> Index: src/c++/libhdfs/hdfsJniHelper.c
> ===================================================================
> --- src/c++/libhdfs/hdfsJniHelper.c	(revision 1124544)
> +++ src/c++/libhdfs/hdfsJniHelper.c	(working copy)
> @@ -442,6 +442,7 @@
>              int argNum = 1;
>              for (;argNum < noArgs ; argNum++) {
>                  options[argNum].optionString = result; //optHadoopArg;
> +                result = strtok( NULL, jvmArgDelims);
>              }
>          }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message