hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1893) Change edit logs and images to be named based on txid
Date Sun, 22 May 2011 07:26:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037521#comment-13037521
] 

Eli Collins commented on HDFS-1893:
-----------------------------------

Hey Todd, looks good. I'm +1 on committing this to the branch. Looks like the TODOs will be
addresses in the BN work. Ivan's point about finalizing log segments seems reasonable to me
as well, agree can be addressed separately. Minor stuff that can be address later:

* Add a comment in FSImage#doUpgrade as to why the version file needs to be written
* I'm not sure I follow the question in FSEditLog#getEditLogSize, the size does make sense
even with the concept of transactions, the CN can use the log size to decide when to roll
(which seems reasonable).
* Define a layout version constant for -31 and use in FSEeditLogLoader

bq. BTW, one nice stat: this patch actually removes more code than it adds in src/java. That's
great feedback that this is indeed less complex than what we did before!

Very cool!

> Change edit logs and images to be named based on txid
> -----------------------------------------------------
>
>                 Key: HDFS-1893
>                 URL: https://issues.apache.org/jira/browse/HDFS-1893
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: hdfs-1893-prelim.txt, hdfs-1893.txt, hdfs-1893.txt, hdfs-1893.txt
>
>
> This is the main subtask of HDFS-1073: actually switch over the naming of the files to
the new format as described in the design doc.
> I imagine it will be split out into a couple separate JIRAs before being committed, but
this still be the "big kahuna" patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message