hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-1978) All but first option in LIBHDFS_OPTS is ignored
Date Sun, 22 May 2011 23:25:47 GMT

     [ https://issues.apache.org/jira/browse/HDFS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brock Noland updated HDFS-1978:
-------------------------------

    Attachment: HDFS-1978.0.patch

The patch attached works on my system (builds and tests) and respects multiple arguments.

Should be be calling free(optHadoopClassPath); as we are passing that into the VM? This code
is nearby but is unchanged in my patch.

> All but first option in LIBHDFS_OPTS is ignored
> -----------------------------------------------
>
>                 Key: HDFS-1978
>                 URL: https://issues.apache.org/jira/browse/HDFS-1978
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 0.21.0
>         Environment: RHEL 5.5
> JDK 1.6.0_24
>            Reporter: Brock Noland
>         Attachments: HDFS-1978.0.patch
>
>
> In getJNIEnv, we go though LIBHDFS_OPTS with strok and count the number of args. Then
create an array of options based on that information. But when we actually setup the options
we only the first arg. I believe the fix is pasted inline.
> {noformat}
> Index: src/c++/libhdfs/hdfsJniHelper.c
> ===================================================================
> --- src/c++/libhdfs/hdfsJniHelper.c	(revision 1124544)
> +++ src/c++/libhdfs/hdfsJniHelper.c	(working copy)
> @@ -442,6 +442,7 @@
>              int argNum = 1;
>              for (;argNum < noArgs ; argNum++) {
>                  options[argNum].optionString = result; //optHadoopArg;
> +                result = strtok( NULL, jvmArgDelims);
>              }
>          }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message