hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1932) Add utility method to initialize HDFS default configurations
Date Sat, 21 May 2011 00:13:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037188#comment-13037188

Aaron T. Myers commented on HDFS-1932:

bq. In terms of testing does the test in HADOOP-7287 fail w/o this patch and succeed with

The test case provided in the patch for HADOOP-7287 does not fail without this patch, since
the bug here is really just that the calls to {{addDeprecation(...)}} never occur without
this patch.

However, the manual test case described in HADOOP-7287 (i.e. `hadoop fs -Ddfs.blocksize=4096
-touchz f1 ;  hadoop fs -stat "%o" f1') does indeed fail without this patch, but succeed with
it. I just tested this manually.

> Add utility method to initialize HDFS default configurations
> ------------------------------------------------------------
>                 Key: HDFS-1932
>                 URL: https://issues.apache.org/jira/browse/HDFS-1932
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Jolly Chen
>            Priority: Critical
>              Labels: newbie
>         Attachments: hdfs-1932-2.txt, hdfs-1932.txt
> Currently we have code blocks like the following in lots of places:
> {code}
>   static{
>     Configuration.addDefaultResource("hdfs-default.xml");
>     Configuration.addDefaultResource("hdfs-site.xml");
>   }
> {code}
> This is dangerous since, if we don't remember to also classload HdfsConfiguration, the
config key deprecations won't work. We should add a method like HdfsConfiguration.init() which
would load the default resources as well as ensure that deprecation gets initialized properly.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message