hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1959) Better error message for missing namenode directory
Date Thu, 19 May 2011 02:40:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035955#comment-13035955
] 

Aaron T. Myers commented on HDFS-1959:
--------------------------------------

I'm no committer, but that +1 is ridiculous. Here's my reasoning:

# The {{if (dir != null)}} check will prevent an NPE at that point, but you'll likely just
get it somewhere else later that assumes that {{dir}} is non-null.
# The change in {{NameNodeResourceChecker}} is a fine one to make, but it doesn't address
the root problem. It's now the place we're relying on to report this error condition. Thing
is, the {{NameNodeResourceChecker}} checks can be entirely disabled via config, in which case
this code will never be hit.

How about we add a proper check for this condition somewhere early-on in Name Node initialization?

> Better error message for missing namenode directory
> ---------------------------------------------------
>
>                 Key: HDFS-1959
>                 URL: https://issues.apache.org/jira/browse/HDFS-1959
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-1959-1.patch
>
>
> Starting the namenode with a missing NN directory currently results in two stack traces,
"Expecting a line not the end of stream" from DF and an NPE. Let's make this more user-friendly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message