hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-977) DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
Date Mon, 30 May 2011 03:32:47 GMT

     [ https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HDFS-977:
-----------------------------

      Resolution: Fixed
    Release Note:   (was: DataNode.createInterDataNodeProtocolProxy() guarded a log at the
wrong level)
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to trunk and 0.22. Thanks Harsh!

P.S. No need to fill in "release note" for small changes like this that users don't need to
know about when upgrading. It's mostly meant for new features or changes an operator/user
should really be aware of.

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: HDFS-977.r1.diff, HDFS-977.r2.diff
>
>
> My IDE tells me that this code snippet in {{DataNode.createInterDataNodeProtocolProxy()}}
is guarding the info log entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message