hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-977) DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
Date Wed, 25 May 2011 14:02:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039132#comment-13039132
] 

Hadoop QA commented on HDFS-977:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12478501/HDFS-977.r1.diff
  against trunk revision 1127390.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/622//console

This message is automatically generated.

> DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-977
>                 URL: https://issues.apache.org/jira/browse/HDFS-977
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Assignee: Harsh J Chouraria
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: HDFS-977.r1.diff
>
>
> My IDE tells me that this code snippet in {{DataNode.createInterDataNodeProtocolProxy()}}
is guarding the info log entry at debug level, and it should be reviewed
> {code}
>     if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
>       InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
>     }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message