Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 79447 invoked from network); 5 Apr 2011 17:57:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Apr 2011 17:57:44 -0000 Received: (qmail 38213 invoked by uid 500); 5 Apr 2011 17:57:44 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 38185 invoked by uid 500); 5 Apr 2011 17:57:44 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 38177 invoked by uid 99); 5 Apr 2011 17:57:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 17:57:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 17:57:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 37F6393531 for ; Tue, 5 Apr 2011 17:57:06 +0000 (UTC) Date: Tue, 5 Apr 2011 17:57:06 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <998658448.35558.1302026226225.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1148) Convert FSDataset to ReadWriteLock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016050#comment-13016050 ] Suresh Srinivas commented on HDFS-1148: --------------------------------------- Todd, I want to understand what methods have lot contention. Also you say: > As I understood it, the non-fair mode is more efficient. Since the lock is mostly uncontended I am not sure what you mean mostly uncontended, because I understand the problem description as there are lot of contentions... > Convert FSDataset to ReadWriteLock > ---------------------------------- > > Key: HDFS-1148 > URL: https://issues.apache.org/jira/browse/HDFS-1148 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-1148-old.txt, patch-HDFS-1148-rel0.20.2.txt > > > In benchmarking HDFS-941 I noticed that for the random read workload, the FSDataset lock is highly contended. After converting it to a ReentrantReadWriteLock, I saw a ~25% improvement on both latency and ops/second. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira