Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 92744 invoked from network); 13 Apr 2011 22:52:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Apr 2011 22:52:46 -0000 Received: (qmail 65170 invoked by uid 500); 13 Apr 2011 22:52:45 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 65137 invoked by uid 500); 13 Apr 2011 22:52:45 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 65129 invoked by uid 99); 13 Apr 2011 22:52:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2011 22:52:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2011 22:52:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BBBE6A0D6D for ; Wed, 13 Apr 2011 22:52:05 +0000 (UTC) Date: Wed, 13 Apr 2011 22:52:05 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <576900392.56340.1302735125765.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <776771168.53537.1302645725811.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-1833) Refactor BlockReceiver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-1833: ----------------------------------------- Attachment: h1833_20110413.patch h1833_20110413.patch: added PacketResponderType. > Refactor BlockReceiver > ---------------------- > > Key: HDFS-1833 > URL: https://issues.apache.org/jira/browse/HDFS-1833 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Priority: Minor > Fix For: 0.23.0 > > Attachments: h1833_20110412.patch, h1833_20110413.patch > > > There are repeated codes for creating log/error messages in BlockReceiver. Also, some comment in the codes are incorrect, e.g. > {code} > private int numTargets; // number of downstream datanodes including myself > {code} > but the count indeed excludes the current datanode. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira