Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66DA7322F for ; Thu, 28 Apr 2011 02:26:42 +0000 (UTC) Received: (qmail 62335 invoked by uid 500); 28 Apr 2011 02:26:42 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 62310 invoked by uid 500); 28 Apr 2011 02:26:42 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 62302 invoked by uid 99); 28 Apr 2011 02:26:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2011 02:26:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2011 02:26:41 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 50FD346A8E for ; Thu, 28 Apr 2011 02:26:03 +0000 (UTC) Date: Thu, 28 Apr 2011 02:26:03 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1709822281.7501.1303957563328.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <850768559.18282.1301380325732.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-1792) Add code to detect valid length of an edits file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026073#comment-13026073 ] Aaron T. Myers commented on HDFS-1792: -------------------------------------- If the proposed change in HDFS-1846 gets checked in before this branch gets merged, you'll need to make a change here. That said, the code can be guaranteed to work, since the edits log will be guaranteed to end with 0xFFs instead of maybe being filled with 0x00s. > Add code to detect valid length of an edits file > ------------------------------------------------ > > Key: HDFS-1792 > URL: https://issues.apache.org/jira/browse/HDFS-1792 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: Edit log branch (HDFS-1073) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: Edit log branch (HDFS-1073) > > Attachments: hdfs-1792.txt > > > In some edit log corruption situations, it's useful to be able to determine the "valid" length of an edit log. For this JIRA we define "valid" as the length of the file excluding any trailing 0x00 bytes, usually left there by the preallocation done while writing. In the future this API can be extended to look at edit checksums, etc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira