From hdfs-issues-return-16583-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org Sun Apr 03 16:28:44 2011 Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 75421 invoked from network); 3 Apr 2011 16:28:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Apr 2011 16:28:44 -0000 Received: (qmail 97246 invoked by uid 500); 3 Apr 2011 16:28:44 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 97212 invoked by uid 500); 3 Apr 2011 16:28:44 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 97198 invoked by uid 99); 3 Apr 2011 16:28:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Apr 2011 16:28:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Apr 2011 16:28:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7E22D90B6E for ; Sun, 3 Apr 2011 16:28:06 +0000 (UTC) Date: Sun, 3 Apr 2011 16:28:06 +0000 (UTC) From: "Ivan Kelly (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <590192093.31310.1301848086513.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1826418763.13691.1299240756959.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HDFS-1725) Cleanup FSImage construction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-1725: ----------------------------- Attachment: HDFS-1725.diff I've removed everything that was related to ensuring that image and edits directories are set from the start. In all it doesn't do very much now, just pushes the FSImage() code around a bit and removes FSImage(URI). I initially created this JIRA because it was possible to change the directories underneath FSImage without going through FSImage. This made it hard to make assumptions about the state of FSImage. This patch in its current form does not fix that, so I wouldn't recommend it for submission. > Cleanup FSImage construction > ---------------------------- > > Key: HDFS-1725 > URL: https://issues.apache.org/jira/browse/HDFS-1725 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 0.23.0 > > Attachments: HDFS-1725.diff, HDFS-1725.diff, HDFS-1725.diff, HDFS-1725.diff, HDFS-1725.diff, HDFS-1725.diff > > > FSImage construction is messy. Sometimes the storagedirectories in use are set straight away, sometimes they are not. This makes it hard for anything under FSImage (i.e. FSEditLog) to make assumptions about what it can use. Therefore, this patch makes FSImage set the storage directories in use during construction, and never allows them to change. If you want to change storagedirectories you create a new image. > Also, all the construction code should be the same with the only difference being the parameters passed. When not passed, these should get sensible defaults. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira