hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1833) Refactor BlockReceiver
Date Wed, 13 Apr 2011 17:14:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019438#comment-13019438
] 

Tsz Wo (Nicholas), SZE commented on HDFS-1833:
----------------------------------------------

Hi Daryn, {{downstreams}} is the replacement of {{numTargets}}, where the values of {{numTargets}}
could be -1, 0 or >0, where the value -1 is used for verifying check sum locally but not
write pipe line.  In the patch, {{downstreams == null}} is for the case {{numTargets == -1}}.

I got [similar questions from Jitendra|https://issues.apache.org/jira/browse/HDFS-1789?focusedCommentId=13012284&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13012284]
earlier.  It probably is still confusing.  Let me think about how to make it more clear.

> Refactor BlockReceiver
> ----------------------
>
>                 Key: HDFS-1833
>                 URL: https://issues.apache.org/jira/browse/HDFS-1833
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: h1833_20110412.patch
>
>
> There are repeated codes for creating log/error messages in BlockReceiver.  Also, some
comment in the codes are incorrect, e.g.
> {code}
> private int numTargets;     // number of downstream datanodes including myself
> {code}
> but the count indeed excludes the current datanode.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message