hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1575) viewing block from web UI broken
Date Fri, 22 Apr 2011 01:52:08 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023077#comment-13023077
] 

Todd Lipcon commented on HDFS-1575:
-----------------------------------

A few issues with the patch:
- style issue: need braces around the if () {...} block
- style issue: continuation of line "path = req.getPathInfo()..." should be indented
- The filename that gets put onto the path needs to get path-encoded. Right now there is an
XSS vulnerability if you name a file something like '">...evilcodehere...'. Note that path-encoding
is different than URLEncoding - particularly in that "/" should not be encoded, and " " turns
to "%20" instead of "+".

> viewing block from web UI broken
> --------------------------------
>
>                 Key: HDFS-1575
>                 URL: https://issues.apache.org/jira/browse/HDFS-1575
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1575
>
>
> DatanodeJspHelper seems to expect the file path to be in the "path info" of the HttpRequest,
rather than in a parameter. I see the following exception when visiting the URL {{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567&blockSize=20&genstamp=1001&filename=%2Fuser%2Ftodd%2Fissue&datanodePort=50010&namenodeInfoPort=50070}}
> java.io.FileNotFoundException: File does not exist: /
> 	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
> ...
> 	at org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
> 	at org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
> 	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message