hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1799) Refactor log rolling and filename management out of FSEditLog
Date Fri, 01 Apr 2011 18:25:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014781#comment-13014781
] 

Todd Lipcon commented on HDFS-1799:
-----------------------------------

Hey Ivan. Yep, I took a look at the latest design in HDFS-1580. Even though it's simplified
from the original design, I'm trying to attack the minimal set of changes necessary for 1073
in this JIRA. In particular:

- Doesn't clean up the constructors for FSImage, FSEditLog, etc (though I agree your changes
are a good improvement)
- Doesn't provide for log-transfer in a generalized way
- Doesn't move directory formatting
- Doesn't provide general pluggability of new implementation classes

What this JIRA does do is simply to move the file-specific operations like "divert" and "revert"
into a FileJournalManager class. This means that the next set of changes will be more localized
to that file. I hope to post another patch on top of that tonight.

It looks like it will be simple to extend from this code to add the other useful features
you're looking at in 1580. Would you disagree?

> Refactor log rolling and filename management out of FSEditLog
> -------------------------------------------------------------
>
>                 Key: HDFS-1799
>                 URL: https://issues.apache.org/jira/browse/HDFS-1799
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Edit log branch (HDFS-1073)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: Edit log branch (HDFS-1073)
>
>         Attachments: hdfs-1799.txt
>
>
> This is somewhat similar to HDFS-1580, but less ambitious. While that JIRA focuses on
pluggability, this task is simply the minimum needed for HDFS-1073:
> - Refactor the filename-specific code for rolling, diverting, and reverting log streams
out of FSEditLog into a new class
> - Clean up the related code in FSEditLog a bit
> Notably, this JIRA is going to temporarily break the BackupNode. I plan to circle back
on the BackupNode later on this branch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message