hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1822) Editlog opcodes overlap between 20 security and later releases
Date Wed, 13 Apr 2011 19:50:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019516#comment-13019516
] 

Allen Wittenauer commented on HDFS-1822:
----------------------------------------

bq. Proposed change seems odd. I understand there was a mistake made while introducing these
ops to 0.20s. So correcting this mistake by introducing a work around into 0.22 and using
it forever is bad.
I did not exactly understood what was vetoed.

To clarify:  Correcting this mistake by adding translation code into trunk is horrific and,
as you pointed out, we'll be stuck with it forever.  It also doesn't fix the problem for someone
going from non-Apache 0.20 -> 0.21.  

I'm also very much opposed to a non-Apache release forcing this sort of change.  Yes, I understand
that people run code from branches all the time. That's a risk/reward calculation that organizations
need to make.  In this case, the risk came true: they aren't compatible anymore.

In any case, I'm much more in favor of:

a) Fixing the Apache branches to use the proper opcodes.
b) Declaring that one must have a fully processed editslog prior to upgrade.  This is a recommended
practice anyway, so I don't see the harm in making it official.

If the group really feels we need to protect Apache releases from non-Apache releases, then
we have to decide what to do about 0.21.  Fixing this in trunk won't protect those users.

> Editlog opcodes overlap between 20 security and later releases
> --------------------------------------------------------------
>
>                 Key: HDFS-1822
>                 URL: https://issues.apache.org/jira/browse/HDFS-1822
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0, 0.22.0, 0.23.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 0.22.0, 0.23.0
>
>         Attachments: HDFS-1822.patch
>
>
> Same opcode are used for different operations between 0.20.security, 0.22 and 0.23. This
results in failure to load editlogs on later release, especially during upgrades.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message