hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1808) TestBalancer waits forever, errs without giving information
Date Tue, 19 Apr 2011 17:46:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021682#comment-13021682
] 

Eli Collins commented on HDFS-1808:
-----------------------------------

Change looks good. If you don't mind let's commit this patch independently so we track different
changes in different jiras. Minor comments:

Nits:
* Rather than pass timeout and allowedRange to waitForHeartBeat I'd have them be constants
in the test function, seems like the tests shouldn't require different values for these parameters.

* Line 199 "0-0.01" should be "0-0.1"
* Line 205 needs indenting


> TestBalancer waits forever, errs without giving information
> -----------------------------------------------------------
>
>                 Key: HDFS-1808
>                 URL: https://issues.apache.org/jira/browse/HDFS-1808
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, name-node
>    Affects Versions: 0.22.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>         Attachments: 1808_TestBalancer_v3.patch, TestBalancer.java.patch
>
>
> In three locations in the code, TestBalancer waits forever on a condition.  Failures
result in Hudson/Jenkins "Timeout occurred" error message with no information about where
or why.  Need to replace with TimeoutExceptions that throw a stack trace and useful info about
the failure mode.
> In waitForHeartBeat(), it is waiting on an exact match for a value that may be coarsely
quantized -- i.e., significant deviation from the exact "expected" result may occur.  Replace
with an allowed range of result.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message