hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashwin Giridharan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1572) Checkpointer should trigger checkpoint with specified period.
Date Mon, 18 Apr 2011 11:31:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020981#comment-13020981
] 

Ashwin Giridharan commented on HDFS-1572:
-----------------------------------------

Sorry.. LCM should not be used. We should be using GCD...

> Checkpointer should trigger checkpoint with specified period.
> -------------------------------------------------------------
>
>                 Key: HDFS-1572
>                 URL: https://issues.apache.org/jira/browse/HDFS-1572
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Liyin Liang
>            Assignee: Jakob Homan
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: 1527-1.diff, 1572-2.diff, HDFS-1572-2.patch, HDFS-1572-3.patch,
HDFS-1572.patch
>
>
> {code:}
>   long now = now();
>   boolean shouldCheckpoint = false;
>   if(now >= lastCheckpointTime + periodMSec) {
>     shouldCheckpoint = true;
>   } else {
>     long size = getJournalSize();
>     if(size >= checkpointSize)
>       shouldCheckpoint = true;
>   }
> {code}
> {dfs.namenode.checkpoint.period} in configuration determines the period of checkpoint.
However, with above code, the Checkpointer triggers a checkpoint every 5 minutes (periodMSec=5*60*1000).
According to SecondaryNameNode.java, the first *if*  statement should be:
>  {code:}
> if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
>  {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message