Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 16600 invoked from network); 12 Mar 2011 14:16:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Mar 2011 14:16:23 -0000 Received: (qmail 15520 invoked by uid 500); 12 Mar 2011 14:16:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 15487 invoked by uid 500); 12 Mar 2011 14:16:23 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 15479 invoked by uid 99); 12 Mar 2011 14:16:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Mar 2011 14:16:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Mar 2011 14:16:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 69A0A39AE03 for ; Sat, 12 Mar 2011 14:15:59 +0000 (UTC) Date: Sat, 12 Mar 2011 14:15:59 +0000 (UTC) From: "Ivan Kelly (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <827532485.15451.1299939359428.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1826418763.13691.1299240756959.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Updated: (HDFS-1725) Cleanup FSImage construction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-1725: ----------------------------- Status: Patch Available (was: Open) > Cleanup FSImage construction > ---------------------------- > > Key: HDFS-1725 > URL: https://issues.apache.org/jira/browse/HDFS-1725 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 0.23.0 > > Attachments: HDFS-1725.diff, HDFS-1725.diff, HDFS-1725.diff > > > FSImage construction is messy. Sometimes the storagedirectories in use are set straight away, sometimes they are not. This makes it hard for anything under FSImage (i.e. FSEditLog) to make assumptions about what it can use. Therefore, this patch makes FSImage set the storage directories in use during construction, and never allows them to change. If you want to change storagedirectories you create a new image. > Also, all the construction code should be the same with the only difference being the parameters passed. When not passed, these should get sensible defaults. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira