Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 28954 invoked from network); 4 Mar 2011 08:37:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Mar 2011 08:37:00 -0000 Received: (qmail 24827 invoked by uid 500); 4 Mar 2011 08:37:00 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24763 invoked by uid 500); 4 Mar 2011 08:37:00 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24587 invoked by uid 99); 4 Mar 2011 08:37:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2011 08:37:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2011 08:36:57 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 12D214FF7B for ; Fri, 4 Mar 2011 08:36:37 +0000 (UTC) Date: Fri, 4 Mar 2011 08:36:37 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <604385763.13313.1299227797073.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <741075750.11967.1299186037013.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Resolved: (HDFS-1718) HDFS Federation: MiniDFSCluster#waitActive() bug causes some tests to fail MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas resolved HDFS-1718. ----------------------------------- Resolution: Fixed Hadoop Flags: [Reviewed] I committed the patch. > HDFS Federation: MiniDFSCluster#waitActive() bug causes some tests to fail > --------------------------------------------------------------------------- > > Key: HDFS-1718 > URL: https://issues.apache.org/jira/browse/HDFS-1718 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Affects Versions: Federation Branch > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: Federation Branch > > Attachments: HDFS-1718.patch > > > MiniDFSCluster#shouldWait() method waits for all the datanodes to come up and register with the namenode. > Due to threading issues some of the tests fail for two reasons: > # Datanode#isDatanodeUp() fails even if all the BPOfferService threads have exited. This is due to Thread.isAlive() > returning true, even though the thread has exited. Adding a check to BPOfferService#shouldService run as an addition, > fixes this issues. > # shouldWait(), where isBPServiceAlive() is called, does not work when a BPOfferService thread fails before the > datanode has discovered the BPID, from handshake with namenode. This can be fixed by checking the thread state using > InetSocketAddress to determine the BPOfferService, instead of BPID. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira