Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 4 Mar 2011 09:05:37 +0000 (UTC)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <489666269.13355.1299229537276.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1886323581.12001.1299186636929.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Updated: (HDFS-1720) Federation: FSVolumeSet volumes is not
 synchronized correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-1720:
----------------------------------

    Attachment: HDFS-1720.1.patch

Updated patch after fixing conflicts.

> Federation: FSVolumeSet volumes is not synchronized correctly 
> --------------------------------------------------------------
>
>                 Key: HDFS-1720
>                 URL: https://issues.apache.org/jira/browse/HDFS-1720
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>    Affects Versions: Federation Branch
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1720.1.patch, HDFS-1720.patch
>
>
> Currently FSVolumeSet#volumes is package private and is exposed to outside classes:
> # Only some methods (such as FSVolumeSet#checkDirs()) are synchronized on FSVolumeSet.this. This method changes the
> content of the array (sets volumes with errors to null).
> # Some access to volumes are synchronized by FSDataset.this. Some access are not synchronized at all.
> I propose making FSVolumeSet#unmodifiable list. This prevents accidental mutation from outside the class. The volumes
> also are created anew when modifications are made.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira