Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 8 Mar 2011 08:59:59 +0000 (UTC)
From: "Uma Maheswara Rao G (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <352964906.3947.1299574799517.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1570328302.3887.1297088850665.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (HDFS-1611) Some logical issues need to address.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003865#comment-13003865 ] 

Uma Maheswara Rao G commented on HDFS-1611:
-------------------------------------------

Provided the patch.
Changed the log level to debug.
Thank you Todd Lipcon for your comments.


> Some logical issues need to address.
> ------------------------------------
>
>                 Key: HDFS-1611
>                 URL: https://issues.apache.org/jira/browse/HDFS-1611
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client, name-node
>    Affects Versions: 0.20.1, 0.20.2
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-1611.1.patch, HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>       ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
>     }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>       e.printStackTrace();
>     }
>   We can avoid using stackTace(). Better to add log message.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira