Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 12 Mar 2011 01:16:59 +0000 (UTC)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1836409091.14987.1299892619841.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1358188106.12207.1299800639489.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (HDFS-1748) Balancer utilization classification
 is incomplete
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005948#comment-13005948 ] 

Suresh Srinivas commented on HDFS-1748:
---------------------------------------

+1 for the patch. Patch looks good.

Minor comment: should belowAvgUtilizedDatanode be renamed belowOrEqualAvgUtilizedDatanode for consistency? However I am ok if you do not want to make this change.


> Balancer utilization classification is incomplete
> -------------------------------------------------
>
>                 Key: HDFS-1748
>                 URL: https://issues.apache.org/jira/browse/HDFS-1748
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1748_20110310.patch
>
>
> {code}
> //Balancer.java
>   /* Return true if the given datanode is overUtilized */
>   private boolean isOverUtilized(BalancerDatanode datanode) {
>     return datanode.utilization > (avgUtilization+threshold);
>   }
>   
>   /* Return true if the given datanode is above average utilized
>    * but not overUtilized */
>   private boolean isAboveAvgUtilized(BalancerDatanode datanode) {
>     return (datanode.utilization <= (avgUtilization+threshold))
>         && (datanode.utilization > avgUtilization);
>   }
>   
>   /* Return true if the given datanode is underUtilized */
>   private boolean isUnderUtilized(BalancerDatanode datanode) {
>     return datanode.utilization < (avgUtilization-threshold);
>   }
>   /* Return true if the given datanode is below average utilized 
>    * but not underUtilized */
>   private boolean isBelowAvgUtilized(BalancerDatanode datanode) {
>         return (datanode.utilization >= (avgUtilization-threshold))
>                  && (datanode.utilization < avgUtilization);
>   }
> {code}
> Where is {{datanode.utilization == avgUtilization}}?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira