Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 29 Mar 2011 02:41:06 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1290502585.18086.1301366466152.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1307979346.12939.1301096465904.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-1789) Refactor frequently used codes from
 DFSOutputStream, BlockReceiver and DataXceiver
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012321#comment-13012321 ] 

Hadoop QA commented on HDFS-1789:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12474843/h1789_20110328.patch
  against trunk revision 1086461.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestHDFSCLI
                  org.apache.hadoop.hdfs.TestDFSShell

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/298//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/298//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/298//console

This message is automatically generated.

> Refactor frequently used codes from DFSOutputStream, BlockReceiver and DataXceiver
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-1789
>                 URL: https://issues.apache.org/jira/browse/HDFS-1789
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h1789_20110325.patch, h1789_20110325b.patch, h1789_20110328.patch
>
>
> Below are frequently used codes 
> - Check block tokens in {{DataXceiver}}
> - Log/error messages in {{BlockReceiver}}
> In addition, I will refactor {{DFSOutputStream}} for testing)
> - create socket for pipeline

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira