Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 44231 invoked from network); 21 Mar 2011 14:25:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Mar 2011 14:25:46 -0000 Received: (qmail 4844 invoked by uid 500); 21 Mar 2011 14:25:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 4798 invoked by uid 500); 21 Mar 2011 14:25:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 4774 invoked by uid 99); 21 Mar 2011 14:25:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2011 14:25:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2011 14:25:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E4A0040293A for ; Mon, 21 Mar 2011 14:25:05 +0000 (UTC) Date: Mon, 21 Mar 2011 14:25:05 +0000 (UTC) From: "Ivan Kelly (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1288766707.641.1300717505933.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <31416615.309351294823386532.JavaMail.jira@thor> Subject: [jira] [Commented] (HDFS-1580) Add interface for generic Write Ahead Logging mechanisms MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009138#comment-13009138 ] Ivan Kelly commented on HDFS-1580: ---------------------------------- This depends on whether we want the roll operation exposed to the user of the JournalManager. In the past this was required as roll had to happen to allow a checkpoint to take place. However, once HDFS-1580 goes in, its not strictly necessary because rolling is stateless. The JournalManager could roll in the background without the user of the class having any knowledge of the roll. To the user, the JournalManager is simply something to open, write to and close. Do you think this simplification is worthwhile? I agree that getOutputStream(txid) everywhere is a bit messy. It also doesnt work. If a roll happens while the OutputStream has been given out the editlog may end up writing to two different streams which could mess up transaction ids. This isn't in any way unsolvable, but I need to think about it more. > Add interface for generic Write Ahead Logging mechanisms > -------------------------------------------------------- > > Key: HDFS-1580 > URL: https://issues.apache.org/jira/browse/HDFS-1580 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Ivan Kelly > Attachments: HDFS-1580+1521.diff, HDFS-1580.diff, generic_wal_iface.pdf, generic_wal_iface.pdf, generic_wal_iface.txt > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira