hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1751) Intrinsic limits for HDFS files, directories
Date Tue, 15 Mar 2011 23:13:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007266#comment-13007266

Boris Shkolnik commented on HDFS-1751:

Ok, so my understanding is that these changes allow to impose some cluster wide limitations
on the length of the names and number of items in a directory.
Unlike quota system - which is per directory.

I still cannot imagine a case where we need a minimum name length check.

Couple more comments:
1. Could you see if you can use mock() for FSNamesystem instead of changing the constructor
for FSDirectory.
2. in your tests seems like testMinComponentsAndMaxDirContents() test covers all the cases.
Do we really need the others (testNoLimits, testMinComponentLength, testMaxComponentLength
and testMaxDirContents).

> Intrinsic limits for HDFS files, directories
> --------------------------------------------
>                 Key: HDFS-1751
>                 URL: https://issues.apache.org/jira/browse/HDFS-1751
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>         Attachments: HDFS-1751-2.patch, HDFS-1751.patch
> Enforce a configurable limit on:
>   the length of a path component
>   the number of names in a directory
> The intention is to prevent a too-long name or a too-full directory. This is not about
RPC buffers, the length of command lines, etc. There may be good reasons for those kinds of
limits, but that is not the intended scope of this feature. Consequently, a reasonable implementation
might be to extend the existing quota checker so that it faults the creation of a name that
violates the limits. This strategy of faulting new creation evades the problem of existing
names or directories that violate the limits.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message