hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1786) Some cli test cases expect a "null" message
Date Sat, 26 Mar 2011 17:24:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011662#comment-13011662
] 

Uma Maheswara Rao G commented on HDFS-1786:
-------------------------------------------

Hi Nicholas,
 I fixed null message releated testcases.
  
TestDFSShell failures are not because of HADOOP-7174 patch.
 I debugged the test failures for TestDFSShell and found the root cause :-)
 Looks this is a bug in FsShellPermissions.java. ( for -chown argument)

 Bease on arguments it is creating the Handlers. when argument is -chown, it is creating ChownHandler.
{code}
 else if (cmd.equals("-chown")) {
      handler = new ChownHandler(argv[startIndex++]);
{code}

But here the problem is, it is not populating owner, group values. just it is calling supper.

{code}
  protected ChownHandler(String cmd) { //for chgrp
      super(cmd);
    }
{code}

Since it is not pupulating setOwner will not be invoked on fileSystem.So permissions will
not change.
 Because of this assertions are failing TestDFSShell. 
After correcting this tests are passing.

Since code change required here, i will raise separate issue for that in HDFS and will give
patch.:-)
 
  

> Some cli test cases expect a "null" message
> -------------------------------------------
>
>                 Key: HDFS-1786
>                 URL: https://issues.apache.org/jira/browse/HDFS-1786
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-1786.patch
>
>
> There are a few tests cases specified in {{TestHDFSCLI}} and {{TestDFSShell}} expecting
"null" messages.
> e.g. in {{testHDFSConf.xml}},
> {code}
>           <expected-output>get: null</expected-output>
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message