hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1760) problems with getFullPathName
Date Thu, 17 Mar 2011 22:55:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008203#comment-13008203
] 

Hadoop QA commented on HDFS-1760:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12473951/HDFS-1760.patch
  against trunk revision 1082263.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReport
                  org.apache.hadoop.hdfs.server.datanode.TestTransferRbw

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/267//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/267//console

This message is automatically generated.

> problems with getFullPathName
> -----------------------------
>
>                 Key: HDFS-1760
>                 URL: https://issues.apache.org/jira/browse/HDFS-1760
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1760.patch
>
>
> FSDirectory's getFullPathName method is flawed.  Given a list of inodes, it starts at
index 1 instead of 0 (based on the assumption that inode[0] is always the root inode) and
then builds the string with "/"+inode[i].  This means the empty string is returned for the
root, or when requesting the full path of the parent dir for top level items.
> In addition, it's not guaranteed that the list of inodes starts with the root inode.
 The inode lookup routine will only fill the inode array with the last n-many inodes of a
path if the array is smaller than the path.  In these cases, getFullPathName will skip the
first component of the relative path, and then assume the second component starts at the root.
 ex. "a/b/c" becomes "/b/c".
> There are a few places in the code where the issue was hacked around by assuming that
a 0-length path meant a hardcoded "/" instead of Path.SEPARATOR.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message