hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Nath Pandey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1755) Hdfs Federation: The BPOfferService must always connect to namenode as the login user.
Date Wed, 16 Mar 2011 22:20:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007713#comment-13007713
] 

Jitendra Nath Pandey commented on HDFS-1755:
--------------------------------------------

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 30 javac compiler warnings (more than the trunk's
current 25 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 system test framework.  The patch passed system test framework compile.

The additional javac warnings are in ReplicaInfo.java and DataStorage.java which are unrelated
to this patch.

The patch was manually tested in a secure cluster setup.


> Hdfs Federation: The BPOfferService must always connect to namenode as the login user.
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-1755
>                 URL: https://issues.apache.org/jira/browse/HDFS-1755
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1755.2.patch, HDFS-1755.3.patch
>
>
>   The BPOfferService thread when started, normally connects to the namenode as the login
user. But in case of refreshNamenodes a new BPOfferService may be started in the context of
an rpc call where the user is dfsadmin. In such a case the connection to the namenode will
fail. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message