hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-780) Revive TestFuseDFS
Date Mon, 14 Mar 2011 21:16:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006638#comment-13006638
] 

Todd Lipcon commented on HDFS-780:
----------------------------------

- why use <exec executable="cp"...> instead of using the built-in ant copy task?
- not clear why you have to redefine test.classpath - is the one that comes from build-contrib.xml
not sufficient?
- why set fs.default.name property in build.xml? This becomes a Java system property which
afaik would be entirely ignored?
- I noticed AM_CPPFLAGS has -D_FILE_OFFSET_BITS=64, but seems to me this should be done with
autoconf AC_SYS_LARGEFILE. Probably out of scope for this review though.
- spelling: "succesfully"
- javadoc for execAssertFalse is incorrect
- might be clearer to call those methods assertExecSucceeds and assertExecFails?
- what's the purpose of the 1 second sleep in createFile? there's some kind of delay between
making a file and it being visible or something? this seems like a suprising semantic and
at least deserves a comment
- in checkFile, maybe need a try...finally to avoid leaving file open on IOE?
- in checkFile, you assume that read won't return less than the whole file. Maybe you could
use IOUtil.copyBytes() into a ByteArrayOutputStream?
- establishMount seems to assume libhdfs is installed in /usr/local/lib? Also uses the outdated
dfs:// URI type instead of hdfs://
- establishMount doesn't seem to check exit code of the mount command?


> Revive TestFuseDFS
> ------------------
>
>                 Key: HDFS-780
>                 URL: https://issues.apache.org/jira/browse/HDFS-780
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: contrib/fuse-dfs
>            Reporter: Eli Collins
>         Attachments: hdfs-780-1.patch, hdfs-780-2.patch, hdfs-780-3.patch
>
>
> Looks like TestFuseDFS has bit rot. Let's revive it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message