hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1720) Federation: FSVolumeSet volumes is not synchronized correctly
Date Fri, 04 Mar 2011 09:07:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002512#comment-13002512
] 

Suresh Srinivas commented on HDFS-1720:
---------------------------------------

testpatch result:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.8)
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec]     -1 system test framework.  The patch failed system test framework compile.

The -1 in system test framework is not related to this patch. It is not expected after merging
trunk to federation branch.



> Federation: FSVolumeSet volumes is not synchronized correctly 
> --------------------------------------------------------------
>
>                 Key: HDFS-1720
>                 URL: https://issues.apache.org/jira/browse/HDFS-1720
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>    Affects Versions: Federation Branch
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1720.1.patch, HDFS-1720.patch
>
>
> Currently FSVolumeSet#volumes is package private and is exposed to outside classes:
> # Only some methods (such as FSVolumeSet#checkDirs()) are synchronized on FSVolumeSet.this.
This method changes the
> content of the array (sets volumes with errors to null).
> # Some access to volumes are synchronized by FSDataset.this. Some access are not synchronized
at all.
> I propose making FSVolumeSet#unmodifiable list. This prevents accidental mutation from
outside the class. The volumes
> also are created anew when modifications are made.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message