hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1728) SecondaryNameNode.checkpointSize is in byte but not MB.
Date Mon, 07 Mar 2011 20:16:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003561#comment-13003561
] 

Hadoop QA commented on HDFS-1728:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472839/h1728_20110307.patch
  against trunk revision 1076696.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.balancer.TestBalancer
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReport
                  org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/234//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/234//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/234//console

This message is automatically generated.

> SecondaryNameNode.checkpointSize is in byte but not MB.
> -------------------------------------------------------
>
>                 Key: HDFS-1728
>                 URL: https://issues.apache.org/jira/browse/HDFS-1728
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.21.1
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1728_20110307.patch
>
>
> The unit of SecondaryNameNode.checkpointSize is byte but not MB as stated in the following
comment.
> {code}
> //SecondaryNameNode.java
>    private long checkpointSize;    // size (in MB) of current Edit Log
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message