hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1611) Some logical issues need to address.
Date Fri, 04 Mar 2011 16:27:37 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002693#comment-13002693
] 

Hadoop QA commented on HDFS-1611:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472668/HDFS-1611.patch
  against trunk revision 1076696.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestFileConcurrentReader

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//console

This message is automatically generated.

> Some logical issues need to address.
> ------------------------------------
>
>                 Key: HDFS-1611
>                 URL: https://issues.apache.org/jira/browse/HDFS-1611
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client, name-node
>    Affects Versions: 0.20.1, 0.20.2
>            Reporter: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>       ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
>     }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>       e.printStackTrace();
>     }
>   We can avoid using stackTace(). Better to add log message.  

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message