hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-1789) Refactor frequently used codes from DFSOutputStream, BlockReceiver and DataXceiver
Date Sat, 26 Mar 2011 04:25:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011550#comment-13011550
] 

Hadoop QA commented on HDFS-1789:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12474675/h1789_20110325.patch
  against trunk revision 1085509.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 22 javac compiler warnings (more than the trunk's
current 21 warnings).

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestHDFSCLI
                  org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
                  org.apache.hadoop.hdfs.TestDFSShell
                  org.apache.hadoop.hdfs.TestFileConcurrentReader

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/289//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/289//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/289//console

This message is automatically generated.

> Refactor frequently used codes from DFSOutputStream, BlockReceiver and DataXceiver
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-1789
>                 URL: https://issues.apache.org/jira/browse/HDFS-1789
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h1789_20110325.patch
>
>
> Below are frequently used codes 
> - Check block tokens in {{DataXceiver}}
> - Log/error messages in {{BlockReceiver}}
> In addition, I will refactor {{DFSOutputStream}} for testing)
> - create socket for pipeline

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message