hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1738) change hdfs jmxget to return an empty string instead of null when an attribute value is not available.
Date Wed, 09 Mar 2011 02:13:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004335#comment-13004335
] 

Hadoop QA commented on HDFS-1738:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12473083/HDFS-1738.patch
  against trunk revision 1079069.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReport
                  org.apache.hadoop.hdfs.TestFileConcurrentReader

    -1 contrib tests.  The patch failed contrib unit tests.

    -1 system test framework.  The patch failed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/242//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/242//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/242//console

This message is automatically generated.

> change hdfs jmxget to return an empty string instead of null when an attribute value
is not available.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1738
>                 URL: https://issues.apache.org/jira/browse/HDFS-1738
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Tanping Wang
>            Assignee: Tanping Wang
>            Priority: Minor
>         Attachments: HDFS-1738.patch
>
>
> Currently the tool, hdfs jmx returns null in case of an attribute value is not available.
 A null pointer exception is thrown and the value of the rest attributes are not printed.
 It makes more sense to return an empty string and continue to print out the values for the
rest attributes.
> Example of current behavior
> $ hdfs jmxget -server gsbl90629.blue.ygrid.yahoo.com -port 8004 -service NameNode,name=NameNodeActivity
> >>>>>>>>jmx name: name=NameNodeActivity,service=NameNode
> tag.ProcessName=NameNode
> java.lang.NullPointerException
> at org.apache.hadoop.hdfs.tools.JMXGet.printAllValues(JMXGet.java:106)
> at org.apache.hadoop.hdfs.tools.JMXGet.main(JMXGet.java:329)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message