hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1736) Break dependency between DatanodeJspHelper and FsShell
Date Tue, 08 Mar 2011 22:54:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004270#comment-13004270
] 

Hadoop QA commented on HDFS-1736:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12473065/HDFS-1736.patch
  against trunk revision 1079069.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.balancer.TestBalancer

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/241//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/241//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/241//console

This message is automatically generated.

> Break dependency between DatanodeJspHelper and FsShell
> ------------------------------------------------------
>
>                 Key: HDFS-1736
>                 URL: https://issues.apache.org/jira/browse/HDFS-1736
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Minor
>              Labels: hadoop
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1736.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> DatanodeJspHelper has an artificial dependency on a date formatter field in FsShell.
 A pending bug is reorganizing the FsShell commands so this field will no longer be available.
 The dependency should be broken by having DataNodeJspHelper contain its own independent date
formatter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message