hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1763) Replace hard-coded option strings with variables from DFSConfigKeys
Date Thu, 17 Mar 2011 05:52:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007825#comment-13007825
] 

Todd Lipcon commented on HDFS-1763:
-----------------------------------

Looks good - went through looking for bloopers and didn't see any. In 3 or 4 tests, they were
setting dfs.block.size and now are setting the correct dfs.blocksize - it's probably the correct
change, but worth being aware of that we're changing behavior of those tests.


> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
>                 Key: HDFS-1763
>                 URL: https://issues.apache.org/jira/browse/HDFS-1763
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent
DFSConfigKeys define, and a couple places where the default is defined multiple places (once
in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone,
and also a pain in that it prevents eclipse from easily showing you all the places where a
particular config option is used. Let's replace all the uses of the hard-coded option strings
with uses of the corresponding variables in DFSConfigKeys.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message