[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008651#comment-13008651
]
Tsz Wo (Nicholas), SZE commented on HDFS-1763:
----------------------------------------------
No problem. Good work, Eli!
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent
DFSConfigKeys define, and a couple places where the default is defined multiple places (once
in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone,
and also a pain in that it prevents eclipse from easily showing you all the places where a
particular config option is used. Let's replace all the uses of the hard-coded option strings
with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|