hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1557) Separate Storage from FSImage
Date Tue, 01 Feb 2011 07:45:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989079#comment-12989079
] 

Todd Lipcon commented on HDFS-1557:
-----------------------------------

I assume Suresh's comments were supposed to go to another JIRA?

I agree with Jakob on the naming for errorStreams()

Another small nit:
- getStorageDirectoryForStream javadoc: "stream to remove" isn't really a good description
of this parameter, since the method itself doesn't remove anything.

Aside from that, it looks good - I pored over the diff for a while and it seems reasonable.
I imagine as we work in the new code we'll find some improvements we can make, but overall
I think the structure is improved.

I'm also running the unit tests through JCarder to make sure we don't have any new lock inversions.
Should be done by morning.

> Separate Storage from FSImage
> -----------------------------
>
>                 Key: HDFS-1557
>                 URL: https://issues.apache.org/jira/browse/HDFS-1557
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1557-branch-0.22.diff, HDFS-1557-branch-0.22.diff, HDFS-1557-trunk.diff,
HDFS-1557-trunk.diff, HDFS-1557-trunk.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff,
HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff
>
>
> FSImage currently derives from Storage and FSEditLog has to call methods directly on
FSImage to access the filesystem. This JIRA is to separate the Storage class out into NNStorage
so that FSEditLog is less dependent on FSImage. From this point, the other parts of the circular
dependency should be easy to fix.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message