hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1650) Fix unit test case: TestReplication
Date Fri, 25 Feb 2011 05:53:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999223#comment-12999223
] 

Konstantin Boudnik commented on HDFS-1650:
------------------------------------------

It seems that number of datanodes in the test is actually 4 according to this {{int numDataNodes
= 4;}} so it isn't very clear why the loop has to be run 3 times only.
Also, it'd great to have a named constant instead of a mere number 3 + comment on top of it:
this will increase the readability of the code.

> Fix unit test case: TestReplication
> -----------------------------------
>
>                 Key: HDFS-1650
>                 URL: https://issues.apache.org/jira/browse/HDFS-1650
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: Federation Branch
>            Reporter: Tanping Wang
>            Assignee: Tanping Wang
>            Priority: Minor
>             Fix For: Federation Branch
>
>         Attachments: HDFS1650.patch
>
>
> TestReplication fails due to null pointer exception. When corrupting/deleting blocks
in TestReplication#testPendingReplicationRetry() the loop should run for 3 datanodes.
> Instead it runs 6 times, resulting in null blockFile returned. Changing the loop to run
3 times.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message